Discussion:
[gentoo-portage-dev] [PATCH] ecompress-file: Support decompressing .lz
Michał Górny
2018-11-17 08:14:20 UTC
Permalink
Signed-off-by: Michał Górny <***@gentoo.org>
---
bin/ecompress-file | 3 +++
1 file changed, 3 insertions(+)

diff --git a/bin/ecompress-file b/bin/ecompress-file
index bc8fe5451..ccc2701c3 100755
--- a/bin/ecompress-file
+++ b/bin/ecompress-file
@@ -29,6 +29,9 @@ compress_file() {
*.lzma|*.xz)
unxz -f "${x}" || __helpers_die "unxz failed"
x=${x%.*};;
+ *.lz)
+ lzip -df "${x}" || __helpers_die "lzip -d failed"
+ x=${x%.lz};;
esac

filtered_args+=( "$x" )
--
2.19.1
Ulrich Mueller
2018-11-17 08:22:59 UTC
Permalink
Post by Michał Górny
---
bin/ecompress-file | 3 +++
1 file changed, 3 insertions(+)
diff --git a/bin/ecompress-file b/bin/ecompress-file
index bc8fe5451..ccc2701c3 100755
--- a/bin/ecompress-file
+++ b/bin/ecompress-file
@@ -29,6 +29,9 @@ compress_file() {
*.lzma|*.xz)
unxz -f "${x}" || __helpers_die "unxz failed"
x=${x%.*};;
+ *.lz)
+ lzip -df "${x}" || __helpers_die "lzip -d failed"
+ x=${x%.lz};;
esac
filtered_args+=( "$x" )
--
2.19.1
Does that mean that portage will gain a dependency on lzip now?

Ulrich
Michał Górny
2018-11-17 08:25:01 UTC
Permalink
Post by Ulrich Mueller
Post by Michał Górny
---
bin/ecompress-file | 3 +++
1 file changed, 3 insertions(+)
diff --git a/bin/ecompress-file b/bin/ecompress-file
index bc8fe5451..ccc2701c3 100755
--- a/bin/ecompress-file
+++ b/bin/ecompress-file
@@ -29,6 +29,9 @@ compress_file() {
*.lzma|*.xz)
unxz -f "${x}" || __helpers_die "unxz failed"
x=${x%.*};;
+ *.lz)
+ lzip -df "${x}" || __helpers_die "lzip -d failed"
+ x=${x%.lz};;
esac
filtered_args+=( "$x" )
--
2.19.1
Does that mean that portage will gain a dependency on lzip now?
No, I don't think that's necessary. That code is a cheap unsupported
hack that throws QA warnings. I need it to support corner case of
PORTAGE_COMPRESS=lzip FEATURES=binpkg-docompress old binpackages after
switching to FEATURES=-binpkg-docompress.
--
Best regards,
Michał Górny
Zac Medico
2018-11-18 03:26:27 UTC
Permalink
Post by Michał Górny
---
bin/ecompress-file | 3 +++
1 file changed, 3 insertions(+)
diff --git a/bin/ecompress-file b/bin/ecompress-file
index bc8fe5451..ccc2701c3 100755
--- a/bin/ecompress-file
+++ b/bin/ecompress-file
@@ -29,6 +29,9 @@ compress_file() {
*.lzma|*.xz)
unxz -f "${x}" || __helpers_die "unxz failed"
x=${x%.*};;
+ *.lz)
+ lzip -df "${x}" || __helpers_die "lzip -d failed"
+ x=${x%.lz};;
esac
filtered_args+=( "$x" )
Looks good, please merge.
--
Thanks,
Zac
Loading...